combobox: Only react to UP/DOWN scroll events
authorTimm Bäder <mail@baedert.org>
Tue, 9 May 2017 06:22:41 +0000 (08:22 +0200)
committerCarlos Garnacho <carlosg@gnome.org>
Thu, 25 May 2017 14:25:59 +0000 (16:25 +0200)
The old else block scrolled down for everything except GDK_SCROLL_UP
scroll events, e.g. for smooth scroll events.

gtk/gtkcombobox.c

index e07a183e9013e56b74a59566ab02c52f484212e2..bcdad85a80b3f09cfd45da249ae62e190daa1d8b 100644 (file)
@@ -1943,7 +1943,7 @@ gtk_combo_box_scroll_event (GtkWidget          *widget,
 {
   GtkComboBox *combo_box = GTK_COMBO_BOX (widget);
   GtkComboBoxPrivate *priv = combo_box->priv;
-  gboolean found;
+  gboolean found = FALSE;
   GtkTreeIter iter;
   GtkTreeIter new_iter;
 
@@ -1953,7 +1953,7 @@ gtk_combo_box_scroll_event (GtkWidget          *widget,
   if (event->direction == GDK_SCROLL_UP)
     found = tree_prev (combo_box, priv->model,
                        &iter, &new_iter);
-  else
+  else if (event->direction == GDK_SCROLL_DOWN)
     found = tree_next (combo_box, priv->model,
                        &iter, &new_iter);